Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google omniauth generator to use Rails Credentials/ENV variables for APP ID and Secrets #124

Open
coolprobn opened this issue Oct 21, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@coolprobn
Copy link
Collaborator

Right now we add a line for the App ID and Secrets like this and ask users to figure out the addition of those values.

config.omniauth :google_oauth2, "APP_ID", "APP_SECRET"

Instead we should take these values from Rails credentials or ENV variables; whatever users prefer.

You can see a similar implementation for this in sentry generator:

Also need to add tests for this change.

@coolprobn coolprobn added the good first issue Good for newcomers label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant