-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing generators to use Rails Credentials or ENV variables for secrets #40
Comments
@choosen I am sorry the issue is not quite clear to me. Could you share some more details? Is this a new feature request or problem with an existing generators? 😊 |
@abhaynikam https://youtu.be/9vaK9nDMbU8?t=584 devise config should encourage to set up it through environment So this is more about existing generator (devise oauth), but that practice should be applied anywhere |
We have added generators for dotenv and Rails also already has Credentials now. I have not looked into the implementation yet for Oauths but if we are using plain text then we definitely need to migrate them off to use ENV or Rails.credentials Please feel free to take this on if you want. Examples for such cases are in new generators:
|
We should encourage people to store credentials outside the codebase.
Currently there are i.e. github credentials stored as plain text in config/github
The text was updated successfully, but these errors were encountered: