Support Client ID as an alternative input to Client Secret

[cloudshiftchris]

GitHub now recommends using the clientId instead of the appId/privateKey

Augment the options to allow clientId/clientSecret, validating that either this pair or appId/privateKey are provided, and pass these options along in the call to createAppAuth.

[gr2m]

Just to clarify, you cannot use the Client Secret, the private key is still required. But the OAuth Client ID is now recommended to be used as a substitute to the numeric app ID for github.com, and probably GitHub Enterprise Server 3.14+

We just shipped support for passing the client ID to Octokit's app authentication strategy:
https://github.com/octokit/auth-app.js/releases/tag/v7.1.0

[joebowbeer]

@cloudshiftchris edit title to clarify that support is sought for using clientId instead of appId?

@gr2m are you saying this is already supported via octokit/auth-app.js#606 ?

[gr2m]

@gr2m are you saying this is already supported via octokit/auth-app.js#606 ?

yes

[BeyondEvil]

So does this mean that we can pass in client ID instead of app ID, and this issue can be closed... or? @gr2m

[joebowbeer]

I think this should be closed. I have used clientId in place of appId