Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated ids in mergeProps causing infinte re-render in strict mode #7655

Open
nwidynski opened this issue Jan 23, 2025 · 0 comments · May be fixed by #7657
Open

Duplicated ids in mergeProps causing infinte re-render in strict mode #7655

nwidynski opened this issue Jan 23, 2025 · 0 comments · May be fixed by #7657

Comments

@nwidynski
Copy link
Contributor

nwidynski commented Jan 23, 2025 •
edited
Loading

Provide a general summary of the issue here

Tracking #7379 (comment) here so it doesn't get lost.

🤔 Expected Behavior?

Duplicated ids should not cause infinite re-render.

😯 Current Behavior

Duplicated ids cause infinite re-render.

💁 Possible Solution

Untangle duplicated ids in mergeProps, keeping track of whether an id was previously sighted.
Alternatively fix the underlying root cause in useId, but currently don't know whats causing the ref safeguard to fail.

🔦 Context

#7379 (comment)

🖥️ Steps to Reproduce

#7379 (comment)

Version

latest

What browsers are you seeing the problem on?

Chrome, Firefox, Safari, Microsoft Edge

If other, please specify.

No response

What operating system are you using?

osx

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response
@nwidynski nwidynski linked a pull request Jan 23, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: infinite re-render on reoccuring ids nwidynski/react-spectrum
1 participant
@nwidynski