Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and release pipeline broken? #12

Open
ScrumpyJack opened this issue Jun 25, 2021 · 6 comments
Open

Build and release pipeline broken? #12

ScrumpyJack opened this issue Jun 25, 2021 · 6 comments

Comments

@ScrumpyJack
Copy link

Would love to try out this project but it seems that the Mac archive contains a windows exe and the windows version contains a mac zip file that contains the zip file again.
Can we have a new release? many thanks

@ajmcateer
Copy link
Owner

Yea there was a bug in the build script I used, Thanks for pointing it out. I fixed it and just released a new version with some improvements.

@ScrumpyJack
Copy link
Author

The Mac build is still very broken. Not sure what's going on. The archive contains MS DLLs, and file names have paths in them.

@ajmcateer
Copy link
Owner

Its an issue with the Powershell module I used to compress the archive. It looks fine on any windows machine but Mac and Linux don't like the way it compresses it. I uploaded new files, let me know how it looks don't have a mac to compare with.

@Piggeldi2013
Copy link

Well - you don't need a mac to open zips, right? ;)

The Zips in BETA2 are still containing a lot of stuff not needed, I think.

Just an excerpt:
image

@ajmcateer
Copy link
Owner

That is the default output of the dotnet build process for Mac. Some of those dll's are probably not needed, but given that I don't have a Mac to test with I don't want to start removing dll's. I could use Trim, but in the past I have had issues with it and again without being able to test don't want to risk it.

I did resolve an issue where zip files on Mac and Linux would convert folders to filenames that is an issue with PowerShell and how it creates Zip files. Which is resolved, but as far as the dll's go they aren't hurting anything, just create a shortcut to launch it and forget they are they. If I get a reliable way to test the Mac release myself I will look into trimming the unneeded dlls, if there are any.

This program is written in C# so even if the dll says Microsoft or Windows it might still be needed to run on Mac there might be some dependency on it in either a package I use or the dotnet library.

@Piggeldi2013
Copy link

Ah ok, my bad.
I was expecting less than that - seems that everything is shipped what is needed to run the program.

Just installed VS Code and the dotnet - maybe there is something I can contribute. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants