New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor modal components #140

Open

3 of 4 tasks

PhearZero opened this issue Jan 28, 2025 · 0 comments · May be fixed by #136 or #139

Open

3 of 4 tasks

♻️ Refactor modal components #140

PhearZero opened this issue Jan 28, 2025 · 0 comments · May be fixed by #136 or #139

Assignees

Member

PhearZero commented Jan 28, 2025

Overview

The modal architecture was gradually overloaded and is a source of fragility.

Refactor all modals to handle their own state to enforce locality of behavior
Refactor ModalEvent to discrete event emitters like EmitShowModal and EmitKeySelected
Refactor the package modal to overlay to separate the concerns
Refactor overlay state loop

The text was updated successfully, but these errors were encountered:

PhearZero self-assigned this

This was linked to pull requests Jan 28, 2025

refactor: modals #136

Open

refactor: overlay events #139

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment