-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipping fails with a single file #15
Comments
Hmm... will have to check this. |
Ah, I see. Hard coded in the code actually! Lines 82 to 84 in 6198556
|
After doing some refactoring (#17) I've come to better understand the codebase. The issue here is that we don't know the files that are being downloaded, and individual files are not downloaded to the source directory (aka we don't even know the file path to potentially add to the zip). I think tracking what files are being downloaded and where, and returning this from the requesting/downloading functions, can unlock a bunch of new functionality; we can log that output to the user (see #14 (comment)), zip the files without using a whole I'll look into how we can do that after finishing up the potential refactors! |
Running
cloneit https://github.com/alok8bb/cloneit/blob/master/install.sh --zip
(orcargo run -- https://github.com/alok8bb/cloneit/blob/master/install.sh --zip
) fails with a zipping error.The text was updated successfully, but these errors were encountered: