Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-App DockableMenuItem Missing Constructor #271

Open
andrewauclair opened this issue Jan 27, 2025 · 1 comment
Open

Multi-App DockableMenuItem Missing Constructor #271

andrewauclair opened this issue Jan 27, 2025 · 1 comment
Labels
bug Something isn't working
Milestone
1.1

Comments

@andrewauclair
Copy link
Owner

The multi-app version of DockableMenuItem is missing the (DockingAPI docking, Supplier<String> persistentIDProvider, String text) constructor to match the single-app DockableMenuItem.
@andrewauclair andrewauclair added the bug Something isn't working label Jan 27, 2025
@andrewauclair andrewauclair added this to the 1.1 milestone Jan 27, 2025
andrewauclair added a commit that referenced this issue Jan 29, 2025
@andrewauclair
Issue #271
f135a62 
Removing commented out constructors and fixing documentation.
@andrewauclair
Copy link
Owner Author

Turns out the constructor is already there. What I was seeing was the old commented out version, copied from the single-app DockableMenuItem. I have removed the commented-out constructors to avoid confusion and updated documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@andrewauclair