Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improve image with css. #1

Open
MichaelDimmitt opened this issue Jun 18, 2019 · 2 comments
Open

Feature Request: Improve image with css. #1

MichaelDimmitt opened this issue Jun 18, 2019 · 2 comments

Comments

@MichaelDimmitt
Copy link
Member

MichaelDimmitt commented Jun 18, 2019

Was going submit a pull request but cant seem to find the code.

Basically adding the following css property to the image:
object-fit: cover;

Without object-fit:
without-object-fit

With object-fit:
with-object-fit

index.html tells me to look at runtime.a66f828dca56eeb90e02.js

@MichaelDimmitt
Copy link
Member Author

@devpato happy to hear any alternative solutions to the problem. 👍

@devpato
Copy link
Member

devpato commented Jun 19, 2019

@MichaelDimmitt Thanks Michael! I noticed that issue before, but I decided to fix it, when I add the other angulers to the page. The main problem is I did this page in a day, and I don't remember in which of the 3 computers i have my code is LOLOL. Now, the solution looks simple and effective, I may use it. Thanks tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants