Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not accept CLA document #10

Closed
3 tasks done
shalva97 opened this issue Mar 7, 2024 · 7 comments
Closed
3 tasks done

Can not accept CLA document #10

shalva97 opened this issue Mar 7, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@shalva97
Copy link

shalva97 commented Mar 7, 2024

Have you read a contributing guide?

  • I have read CONTRIBUTING.md
  • I have searched the existing issues and didn't find any that were similar
  • I have considered creating a pull request with fixes instead of a bug report and want to proceed

Current Behavior

I was asked to agree on CLA here anyproto/anytype-kotlin#979, but in the PR it already has a check and I did write I have read the CLA Document and I hereby sign the CLA. One more issue is that I can not reopen the PR, it says This conversation has been locked and limited to collaborators.

Expected Behavior

It still does not count that I agreed to CLA doc

Steps To Reproduce

Send a PR, add check next to I understand that contributing to this repository will require me to agree with the CLA and add text I have read the CLA Document and I hereby sign the CLA

Environment

- OS: MacOS
- Version:

Anything else?

I know the format of this issue is weird but Github does not let me create an empty issue.

@uburoiubu can you help?

@shalva97 shalva97 added the bug Something isn't working label Mar 7, 2024
@shalva97 shalva97 changed the title How do I accept CLA document Can not accept CLA document Mar 7, 2024
@fuksman fuksman transferred this issue from anyproto/anytype-kotlin Mar 7, 2024
@fuksman fuksman self-assigned this Mar 7, 2024
@fuksman
Copy link
Member

fuksman commented Mar 7, 2024

Hi, I don't see a comment with a required message, just the one with "recheck" message. Here is one of the examples of correctly signed CLA request: anyproto/anytype-ts#522

@shalva97
Copy link
Author

shalva97 commented Mar 7, 2024

Sorry I wanted to post this issue on https://github.com/anyproto/anytype-kotlin

Anyway, I can't add comment or reopen the PR
Screenshot 2024-03-07 at 18 10 16

@fuksman
Copy link
Member

fuksman commented Mar 7, 2024

All good. I'm the one who moved it to another repository.
Yes, the previous pull request is closed. That's why it's impossible to comment. Please open a new pull request and follow the instructions of the CLA Bot.

@shalva97
Copy link
Author

shalva97 commented Mar 7, 2024

Comeon man, why so many extra steps? how can I open a new PR, with what changes? or how is it going to be related to image that already got merged?

@fuksman
Copy link
Member

fuksman commented Mar 7, 2024

They are just regular steps. The fact that the previous PR was closed as merged is our mistake. We apologize for this. It goes against our process to merge contributions without a signed CLA. The image has not been merged; you can check the original repository history. Therefore, the new PR can simply consist of this exact change: adding the image. Once you complete that, you will be recognized as a contributor.

@shalva97
Copy link
Author

shalva97 commented Mar 8, 2024

Im confused regarding what really happened to this anyproto/anytype-kotlin#979 PR. It does say it got merged and shows an option to delete branch or revert it. But at the same time there is no picture in https://github.com/anyproto/anytype-kotlin/tree/main/.idea

this commit shalva97/anytype-kotlin@9632136 is even more strange, I dont get it how did it appear on my fork... 🤯 Is there a bug with Github or something?

@shalva97
Copy link
Author

shalva97 commented Mar 8, 2024

ANyway, I have send another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants