Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust PCRE2 monkey patches #510

Open
Blacksmoke16 opened this issue Jan 31, 2025 · 0 comments
Open

Adjust PCRE2 monkey patches #510

Blacksmoke16 opened this issue Jan 31, 2025 · 0 comments
Labels
component:routing kind:maintenance Keeping an existing feature functional

Comments

@Blacksmoke16
Copy link
Member

Blacksmoke16 commented Jan 31, 2025 •
edited
Loading

crystal-lang/crystal#15395 is making some changes to PCRE2 implementation. When merged this is likely going to break nightly CI due to the routing component needing to monkey patch the logic to add MARK verb support. Will need to add some compare_version checks to make it compatible with both, at least until the next release is out. Then we can make that the min supported version.
@Blacksmoke16 Blacksmoke16 added component:routing kind:maintenance Keeping an existing feature functional labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:routing kind:maintenance Keeping an existing feature functional
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Blacksmoke16