From 61d8f3f96a430632bdecc4afad5d085d30f84d7a Mon Sep 17 00:00:00 2001 From: Karina Thomas Date: Mon, 20 Jan 2025 13:19:58 +0000 Subject: [PATCH 1/5] Ignore react-router and react-router-dom as there are too many breaking changes --- .github/dependabot.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 107fd7f7e3b..b8e1889098b 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -17,6 +17,9 @@ updates: # Opera Mini unsupported packages - dependency-name: 'uuid' # https://github.com/bbc/simorgh/pull/11840 - dependency-name: '@types/uuid' # https://github.com/bbc/simorgh/pull/11840 + # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-1478 react-router & react-router-dom + - dependency-name: 'react-router-dom' + - dependency-name: 'react-router' labels: - 'dependencies' groups: From d5ffc013b61e93386e911fe87c5e35e6cf7e8b03 Mon Sep 17 00:00:00 2001 From: Karina Thomas Date: Mon, 20 Jan 2025 13:51:58 +0000 Subject: [PATCH 2/5] Ignore path-to-regexp as it will shortly no longer be required in Simorgh --- .github/dependabot.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index b8e1889098b..3484582ea46 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -20,6 +20,8 @@ updates: # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-1478 react-router & react-router-dom - dependency-name: 'react-router-dom' - dependency-name: 'react-router' + # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-2099: Delete path-to-regexp dependency + - dependency-name: 'path-to-regexp' labels: - 'dependencies' groups: From a1ae04b8036ba3002cd1e439d813b0cbab2b03b2 Mon Sep 17 00:00:00 2001 From: Karina Thomas Date: Mon, 20 Jan 2025 13:56:05 +0000 Subject: [PATCH 3/5] Include @typescript-eslint/eslint-plugin in ignored dependencies due to eslint v9 having breaking changes --- .github/dependabot.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 3484582ea46..d3629c2657d 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -10,8 +10,11 @@ updates: - dependency-name: 'webpack' update-types: ['version-update:semver-major'] - dependency-name: 'winston' + # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-2185: Latest version of eslint has breaking changes - dependency-name: eslint update-types: ['version-update:semver-major'] + - dependency-name: '@typescript-eslint/eslint-plugin' + update-types: ['version-update:semver-major'] # Latest version of Emotion contains a memory leak that needs resolved: https://github.com/emotion-js/emotion/issues/3221 - dependency-name: '@emotion/*' # Opera Mini unsupported packages From e588a1235731b76fcdd6b83ec5c45f6285780225 Mon Sep 17 00:00:00 2001 From: Karina Thomas Date: Mon, 20 Jan 2025 13:59:24 +0000 Subject: [PATCH 4/5] Add JIRA ticket for emotion upgrade --- .github/dependabot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index d3629c2657d..efab2410b2e 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -15,7 +15,7 @@ updates: update-types: ['version-update:semver-major'] - dependency-name: '@typescript-eslint/eslint-plugin' update-types: ['version-update:semver-major'] - # Latest version of Emotion contains a memory leak that needs resolved: https://github.com/emotion-js/emotion/issues/3221 + # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-2186: Latest version of Emotion contains a memory leak that needs resolved: https://github.com/emotion-js/emotion/issues/3221 - dependency-name: '@emotion/*' # Opera Mini unsupported packages - dependency-name: 'uuid' # https://github.com/bbc/simorgh/pull/11840 From 8cb2cc4e4a42ac5de21b27a13853c1f8a534166d Mon Sep 17 00:00:00 2001 From: Karina Thomas Date: Mon, 20 Jan 2025 14:05:42 +0000 Subject: [PATCH 5/5] Ignore react until breaking changes are resolved --- .github/dependabot.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index efab2410b2e..5e3a0a37b7f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -25,6 +25,11 @@ updates: - dependency-name: 'react-router' # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-2099: Delete path-to-regexp dependency - dependency-name: 'path-to-regexp' + # https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-2187: Latest major version of react has breaking changes + - dependency-name: 'react' + update-types: ['version-update:semver-major'] + - dependency-name: '@types/react' + update-types: ['version-update:semver-major'] labels: - 'dependencies' groups: