Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement and style of exclamation mark on Toast #443

Open
sylar-zeyangz opened this issue Jan 23, 2025 · 3 comments
Open

Placement and style of exclamation mark on Toast #443

sylar-zeyangz opened this issue Jan 23, 2025 · 3 comments

Comments

@sylar-zeyangz
Copy link
Collaborator

Please refer to desktop/src/renderer/src/components/Toast.tsx

The placement and style of exclamation mark are different. Style/color might be less valuable to change, but at least the placement should be aligned to the title instead of a fixed coordinate.

Current behavior:
Image

Design:
Image

@BradyMitch
Copy link
Collaborator

Isabella is aware of this and it is a limitation of the react-toast component. With a lot more time im sure we could fix it but it was decided this was good enough to proceed.

@sylar-zeyangz
Copy link
Collaborator Author

Same with check mark
Image

@Bottle7
Copy link
Collaborator

Bottle7 commented Jan 31, 2025

Can this be closed now? It seems that this won't be addressed due to time and technical constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants