Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary regex syntax errors #44

Open
GoogleCodeExporter opened this issue Mar 17, 2015 · 0 comments
Open

Fix binary regex syntax errors #44

GoogleCodeExporter opened this issue Mar 17, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

I'm receiving syntax errors in some of the checks which use 
`binary_matches_string_grep`. For example, running a check from 
lib/checks/privileged_arguments manually:

 sh-4.3$ y="`binary_matches_string_grep \"/tmp/foo\" \"\$[\{]*[[:digit:]][\}]*\"`"
 sh: \{: syntax error: operand expected (error token is "\{")

Patch attached.

It seems to me that the privileged_environment_variables check will alert for 
any script using $-style variables, not necessarily environment variables. So, 
I'm a bit concerned as to how noisy it will be.

Original issue reported on code.google.com by JJC...@googlemail.com on 2 Mar 2015 at 11:53

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant