Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "type": "module" to package.json #568

Open
benmccann opened this issue Aug 7, 2023 · 2 comments
Open

Add "type": "module" to package.json #568

benmccann opened this issue Aug 7, 2023 · 2 comments
Labels
Priority: Medium Bug, issue, or pull request is a P2 Type: Proposal Issue or pull requests contains a new proposal

Comments

@benmccann
Copy link
Contributor

Svelte libraries should generally contain "type": "module" in package.json`

Probably the hardest part would be dealing with the tests. They should be migrated to ESM. If you upgrade to the latest version of svelte-jester it will only support ESM. The svelte-jester README will describe how to set this up. Alternatively, vitest could be used

@dysfunc dysfunc added Type: Proposal Issue or pull requests contains a new proposal Priority: Medium Bug, issue, or pull request is a P2 labels Dec 7, 2023
@dysfunc
Copy link
Collaborator

dysfunc commented Dec 18, 2023

@benmccann I was wondering if you wouldn't mind joining our slack https://join.slack.com/t/sveltestrap/shared_invite/zt-28y9c8a8k-6~9UI~26Cx7pF1JKeQZPyA. I had something I wanted to run by you/review for an upcoming release.

@benmccann
Copy link
Contributor Author

I'm not sure if I'll have a chance to jump on Slack, but you can find me on Discord here: https://svelte.dev/chat. I have the same username there and on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Bug, issue, or pull request is a P2 Type: Proposal Issue or pull requests contains a new proposal
Projects
None yet
Development

No branches or pull requests

2 participants