Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On option to repeat the last received SPS,PPS and IDR #1238

Closed
neilyoung opened this issue Nov 10, 2022 · 5 comments
Closed

On option to repeat the last received SPS,PPS and IDR #1238

neilyoung opened this issue Nov 10, 2022 · 5 comments

Comments

@neilyoung
Copy link

Describe the feature

This FR is a quick shot following this discussion #1236

Would it be possible to have an option, that rtsp-simple-server streams out the last received SPS, PPS, IDR NAL unit in order to repeat that periodically (configurable?) for client sessions?

TIA

@aler9
Copy link
Member

aler9 commented Nov 11, 2022

rtsp-simple-server already inserts SPS and PPS before I-frames in RTMP, HLS and WebRTC.
It doesn't do that in RTSP, since SPS and PPS are passed to clients during the handshake phase, inside the SDP.

Re-streaming IDRs is not a good idea as it would corrupt the stream, while it's a good idea to send the last IDR to clients that have just joined the stream - this feature is being tracked here: #1209

@aler9 aler9 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2022
@neilyoung
Copy link
Author

Re-streaming IDRs is not a good idea as it would corrupt the stream,

Sure agree on this.

while it's a good idea to send the last IDR to clients that have just joined the stream

Not sure. You might see a bit of the past then :) I would be just happy, if I wouldn't just have to sit and wait for the intra frame. But again, as said on the other thread - not a big issue anymore.

Maybe one day W3C finally confirms the "getKeyFrame" API which is in beginning standardisation and browsers will implement that. I would some indication of a beginning RTSP client session then (I think I have seen you are able to run a command on that?), so that I could use my signaling or data channels in order to "kick-ass" the browsers to send an intra frame as "clean sweep" :)

@aler9
Copy link
Member

aler9 commented Nov 11, 2022

Maybe one day W3C finally confirms the "getKeyFrame" API

this is already implemented with RTCP's PictureLossIndication, please see the other discussion

@neilyoung
Copy link
Author

this is already implemented with RTCP's PictureLossIndication, please see the other discussion

Well, ok. But you would have to have access to this protocol layer, wouldn't you? I don't have that with KMS, unfortunately.

@github-actions
Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants