From f43f98b6fd6f804e1e88632d053b5bd647f9879c Mon Sep 17 00:00:00 2001 From: Brendan Gregg Date: Thu, 17 Aug 2017 15:13:27 -0700 Subject: [PATCH] tweak event warning --- stackcollapse-perf.pl | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/stackcollapse-perf.pl b/stackcollapse-perf.pl index 17dbffd1..e91f7deb 100755 --- a/stackcollapse-perf.pl +++ b/stackcollapse-perf.pl @@ -83,6 +83,8 @@ sub remember_stack { my $tidy_generic = 1; # clean up function names a little my $target_pname; # target process name from perf invocation my $event_filter = ""; # event type filter, defaults to first encountered event +my $event_defaulted = 0; # whether we defaulted to an event (none provided) +my $event_warning = 0; # if we printed a warning for the event my $show_inline = 0; my $show_context = 0; @@ -221,8 +223,15 @@ sub inline { # event type. Merging together different types, such as # instructions and cycles, produces misleading results. $event_filter = $event; - print STDERR "Filtering for events of type: $event\n"; + $event_defaulted = 1; } elsif ($event ne $event_filter) { + if ($event_defaulted and $event_warning == 0) { + # only print this warning if necessary: + # when we defaulted and there was + # multiple event types. + print STDERR "Filtering for events of type: $event\n"; + $event_warning = 1; + } next; } }