BP-4146 Don't require CSP if it is disabled

[JosRomateFashcom]

I get the following error after updating to 1.51.0
Magento version I use: Magento ver. 2.4.7-p3

Error: Cannot instantiate interface Magento\Csp\Model\Collector\MergerInterface in /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:50
Stack trace:
#0 /vendor/magento/framework/ObjectManager/ObjectManager.php(73): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Csp\Mod...')
#1 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(170): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Csp\Mod...')
#2 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(276): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, 'Magento\Csp\Mod...', NULL, 'merger', 'Magento\Csp\Mod...')
#3 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(239): Magento\Framework\ObjectManager\Factory\AbstractFactory->getResolvedArgument('Magento\Csp\Mod...', Array, Array)
#4 /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\Csp\Mod...', Array, Array)
#5 /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\Csp\Mod...', Array, Array)
#6 /vendor/magento/framework/ObjectManager/ObjectManager.php(73): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Csp\Mod...')
#7 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(170): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Csp\Mod...')
#8 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(276): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, 'Magento\Csp\Mod...', NULL, 'dynamicCollecto...', 'Magento\Csp\Hel...')
#9 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(239): Magento\Framework\ObjectManager\Factory\AbstractFactory->getResolvedArgument('Magento\Csp\Hel...', Array, Array)
#10 /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\Csp\Hel...', Array, Array)
#11 /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\Csp\Hel...', Array, Array)
#12 /vendor/magento/framework/ObjectManager/ObjectManager.php(73): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Csp\Hel...')
#13 /vendor/buckaroo/magento2/Factory/CspNonceProviderFactory.php(44): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Csp\Hel...')
#14 /vendor/buckaroo/magento2/Observer/AddCspNonce.php(20): Buckaroo\Magento2\Factory\CspNonceProviderFactory->create()
#15 /vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(121): Buckaroo\Magento2\Observer\AddCspNonce->__construct(Object(Buckaroo\Magento2\Factory\CspNonceProviderFactory))
#16 /vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(66): Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject('Buckaroo\Magent...', Array)
#17 /vendor/magento/framework/ObjectManager/ObjectManager.php(73): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Buckaroo\Magent...')
#18 /vendor/magento/framework/Event/ObserverFactory.php(36): Magento\Framework\ObjectManager\ObjectManager->get('Buckaroo\Magent...')
#19 /vendor/magento/framework/Event/Invoker/InvokerDefault.php(72): Magento\Framework\Event\ObserverFactory->get('Buckaroo\Magent...')
#20 /vendor/magento/framework/Event/Manager.php(65): Magento\Framework\Event\Invoker\InvokerDefault->dispatch(Array, Object(Magento\Framework\Event\Observer))
#21 /generated/code/Magento/Framework/Event/Manager/Proxy.php(105): Magento\Framework\Event\Manager->dispatch('view_block_abst...', Array)
#22 /vendor/magento/framework/View/Element/AbstractBlock.php(668): Magento\Framework\Event\Manager\Proxy->dispatch('view_block_abst...', Array)
#23 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\View\Element\AbstractBlock->toHtml()
#24 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\View\Element\Template\Interceptor->___callParent('toHtml', Array)
#25 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\View\Element\Template\Interceptor->Magento\Framework\Interception{closure}()
#26 /generated/code/Magento/Framework/View/Element/Template/Interceptor.php(302): Magento\Framework\View\Element\Template\Interceptor->___callPlugins('toHtml', Array, Array)
#27 /vendor/magento/framework/View/Result/Page.php(253): Magento\Framework\View\Element\Template\Interceptor->toHtml()
#28 /vendor/magento/framework/View/Result/Layout.php(171): Magento\Framework\View\Result\Page->render(Object(Magento\Framework\App\Response\Http\Interceptor))
#29 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\View\Result\Layout->renderResult(Object(Magento\Framework\App\Response\Http\Interceptor))
#30 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\View\Result\Page\Interceptor->___callParent('renderResult', Array)
#31 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\View\Result\Page\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Response\Http\Interceptor))
#32 /generated/code/Magento/Framework/View/Result/Page/Interceptor.php(95): Magento\Framework\View\Result\Page\Interceptor->___callPlugins('renderResult', Array, Array)
#33 /vendor/magento/framework/App/Http.php(120): Magento\Framework\View\Result\Page\Interceptor->renderResult(Object(Magento\Framework\App\Response\Http\Interceptor))
#34 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http->launch()
#35 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor->___callParent('launch', Array)
#36 /vendor/justbetter/magento2-sentry/Plugin/GlobalExceptionCatcher.php(39): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception{closure}()
#37 /vendor/magento/framework/Interception/Interceptor.php(135): JustBetter\Sentry\Plugin\GlobalExceptionCatcher->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))
#38 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception{closure}()
#39 /generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http\Interceptor->___callPlugins('launch', Array, NULL)
#40 /vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#41 /pub/index.php(95): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#42 {main}

[Buckaroo-Rene]

Hi @JosRomateFashcom ,

Thank you for contacting us about this issue, we'll take a look at it.
Keep you posted.

[Buckaroo-Rene]

Hi @JosRomateFashcom ,

Is it correct that CSP is completely disabled on that environment/staging?

[JosRomateFashcom]

yes 'Magento_Csp' => 0 it is disabled.

[Buckaroo-Rene]

Hi @JosRomateFashcom ,

Thank you for your reply. Currently, the plugin relies on CSP being enabled, primarily for security reasons.
However, we understand that CSP might be disabled in certain scenarios, such as testing in a staging environment.

To address this, we’ve devised a potential solution that checks whether CSP is enabled within the Magento environment.
That said, our developers have unfortunately not been able to reproduce the exact error you reported.

To ensure we can resolve this issue for you, would it be possible to provide temporary access to a staging environment?
This would allow us to verify if the issue is resolved or identify any further adjustments needed on our side.
If this is an option, please reach out to our technical support team at support@buckaroo.nl, and we’ll take it from there.

Another option is that we share a PR that you can test, but that's a bit tricky since we did not get the exact same error.

Looking forward to your reply!