Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt 8 cleanup: Remove C8 license properties from UIConfiguration API #4738

Open
1 task
Tracked by #4755
PHWaechtler opened this issue Oct 21, 2024 · 2 comments
Open
1 task
Tracked by #4755
Labels
scope:optimize Changes to Optimize. type:task Issues that are a change to the project that is neither a feature nor a bug fix.

Comments

@PHWaechtler
Copy link
Contributor

PHWaechtler commented Oct 21, 2024

With https://github.com/camunda/camunda-optimize/issues/12594, we fork optimize into two versions. Since we moved Optimize 8 into the mono repo, the Optimize repo needs to be cleaned up from any code related to Optimize 8.

Acceptance Criteria (Required on creation)

  • C8 license properties are removed from UIConfiguration

Hints

It is not clear to me which ones the C8 license properties are, may reach out to @matthewBearCamunda to clarify.

Links

Sub task of https://github.com/camunda/camunda-optimize/issues/13807

Breakdown

Pull Requests

Preview Give feedback
No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@PHWaechtler PHWaechtler added type:task Issues that are a change to the project that is neither a feature nor a bug fix. scope:optimize Changes to Optimize. labels Oct 21, 2024
@matthewBearCamunda
Copy link

matthewBearCamunda commented Oct 21, 2024

@PHWaechtler - The license cosw for the Optimize repo was added with this PR: camunda/camunda#21199 I'd imagine most of it would need to be removed for C7.

As for the properties on the ui-config endpoint, there are two. validLicense and licenseType

@PHWaechtler
Copy link
Contributor Author

@matthewBearCamunda We just checked and it looks like there are no fields with those names in the UiConfigurationResponseDto currently, but we also dont see that these fields were added/removed in recent commits to the file. The PR you linked is for the monorepo, was there an equivalent for the Optimize repo as well? Or were these fields never added for hybrid Optimize versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:optimize Changes to Optimize. type:task Issues that are a change to the project that is neither a feature nor a bug fix.
Projects
None yet
Development

No branches or pull requests

2 participants