Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define GameState #132

Open
charleskawczynski opened this issue Jul 17, 2023 · 2 comments
Open

Define GameState #132

charleskawczynski opened this issue Jul 17, 2023 · 2 comments

Comments

@charleskawczynski
Copy link
Owner

We should define something like GameState, which should be lossless in terms of game state information
@charleskawczynski
Copy link
Owner Author

Users should be able to query the game state during any of their turns

@charleskawczynski
Copy link
Owner Author

This will be breaking since the existing game state is just preflop, flop etc.

@charleskawczynski charleskawczynski mentioned this issue Jul 18, 2023
Merged
bors bot added a commit that referenced this issue Jul 18, 2023
@bors @charleskawczynski
Merge #136
35fd4ea 
136: Improve names r=charleskawczynski a=charleskawczynski

This PR:
 - Changes the game `state` to `stage` (for now). We'll want to add a proper game state (#132)
 - Add docs to clarify distinction between the player seat number, index, cyclic index and non-cyclic index. This really helps improve readability and simplicity since sometimes we used `id`, `state` `i_circ` (`circle_index`).

Next, we can apply similar name improvements to the transactions section.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this issue Jul 18, 2023
@bors @charleskawczynski
Merge #136
263c805 
136: Improve names r=charleskawczynski a=charleskawczynski

This PR:
 - Changes the game `state` to `stage` (for now). We'll want to add a proper game state (#132)
 - Add docs to clarify distinction between the player seat number, index, cyclic index and non-cyclic index. This really helps improve readability and simplicity since sometimes we used `id`, `state` `i_circ` (`circle_index`).

Next, we can apply similar name improvements to the transactions section.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charleskawczynski