Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for NETWORK variable #3845

Open
VictorEijkhout opened this issue Oct 15, 2024 · 2 comments
Open

Add test for NETWORK variable #3845

VictorEijkhout opened this issue Oct 15, 2024 · 2 comments

Comments

@VictorEijkhout
Copy link

If the variable NETWORK is not set, CMake crashes. Please add a test for this being set before line 41.

@mayantaylor
Copy link
Collaborator

Can you clarify how you are running into this issue? Building Charm via the ./build script should not run into this problem. I'm wondering what the use case is for building via cmake direclty (this relates to your other issue as well I think)

@VictorEijkhout
Copy link
Author

The use case for using cmake is that I have a build system that sets up all directories and such, and I only have to specify

CMAKEFLAGS= blah blah blah

and then everything builds.

Custom build scripts mean that I have to set up all that stuff by hand. A cmake installatin means that half an hour from downloading I have a package installed on 4 clusters times 3 compilers each.

Please use an industry standard rather than rolling your own install script. Please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants