You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have verified this is the correct repository for opening this issue.
I have verified no other issues exist related to my request.
Is Your Feature Request Related To A Problem? Please describe.
When we are accepting pull requests, there are a number of checks that we would like to keep in our minds to ensure we're not making more work for ourselves in the future. It would be good to add these to the PR template so that we can ensure they are done.
Describe The Solution. Why is it needed?
Notice on many forms there are sections labeled "For Office Use Only". The purpose of these sections is for the company to ensure that they complete various processes. Likewise adding this section to the PRs is a reminder for Chocolatey maintainers to ensure various things are covered off.
Some examples:
Does this PR affect other Chocolatey products that may need a corresponding change?
For example: Chocolatey Licensed Extension, Chocolatey GUI, Chocolatey Agent, Boxstarter(?), etc.
Is the PR attached to an Issue that's been attached to a milestone?
Do any of these changes need to be made to other branches?
For example: Updates to just the Pester tests likely need to be pulled into the master branch so that hotfixes are getting the full suite of tests.
Additional Context
This came up during discussion at the Engineering Team Meeting December 21, 2023 (not recorded, nor were minutes taken, was more of a standup than a regular meeting).
Related Issues
No response
The text was updated successfully, but these errors were encountered:
The discussion was mostly because we realized there are scenarios where we need to make sure we're porting between branches and repositories and it's easy to miss. So adding a "for office use only" section could help us ensure we assess these things. (Kind of like the Acceptance Criteria and Done Checklist, but mainly for the merger to ensure.
corbob
added
the
0 - Backlog
Issue is accepted, but is not ready to be worked on or not in current sprint
label
Dec 21, 2023
corbob
added a commit
to corbob/chocolatey.github
that referenced
this issue
Nov 28, 2024
Checklist
Is Your Feature Request Related To A Problem? Please describe.
When we are accepting pull requests, there are a number of checks that we would like to keep in our minds to ensure we're not making more work for ourselves in the future. It would be good to add these to the PR template so that we can ensure they are done.
Describe The Solution. Why is it needed?
Notice on many forms there are sections labeled "For Office Use Only". The purpose of these sections is for the company to ensure that they complete various processes. Likewise adding this section to the PRs is a reminder for Chocolatey maintainers to ensure various things are covered off.
Some examples:
master
branch so that hotfixes are getting the full suite of tests.Additional Context
This came up during discussion at the Engineering Team Meeting December 21, 2023 (not recorded, nor were minutes taken, was more of a standup than a regular meeting).
Related Issues
No response
The text was updated successfully, but these errors were encountered: