Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defunct Makefile targets #65

Open
KueZie opened this issue May 23, 2024 · 1 comment
Open

Remove defunct Makefile targets #65

KueZie opened this issue May 23, 2024 · 1 comment

Comments

@KueZie
Copy link
Collaborator

KueZie commented May 23, 2024

Root Makefile contains defuct targets including but not limited to:

install:
  python3 -m venv .
  . bin/activate && pip install -r requirements-dev.txt

This functionality seems to have been ported to tox.ini and was never removed.
@slott56
Copy link
Collaborator

slott56 commented May 23, 2024

After looking at the Makefile, my suggestion on deleting was a bad idea.

I don't think it should be deleted. I think it needs to be rewritten to use poetry properly instead of trivially deleted.

@slott56 slott56 mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slott56 @KueZie