From 040672d6a1eac34bee72e796ac352ca4d83a9883 Mon Sep 17 00:00:00 2001
From: Felix Hanau <felix@cloudflare.com>
Date: Fri, 24 Jan 2025 17:05:57 -0500
Subject: [PATCH] [EXP] Attempt to fix Windows build

---
 .github/workflows/_bazel.yml | 2 +-
 .github/workflows/test.yml   | 3 +--
 build/js_capnp_library.bzl   | 4 ----
 src/node/BUILD.bazel         | 6 +++++-
 src/pyodide/BUILD.bazel      | 2 +-
 src/wpt/BUILD.bazel          | 3 ++-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/_bazel.yml b/.github/workflows/_bazel.yml
index b1d3887d19e..938638d0a21 100644
--- a/.github/workflows/_bazel.yml
+++ b/.github/workflows/_bazel.yml
@@ -87,7 +87,7 @@ jobs:
       - name: Bazel test
         if: inputs.run_tests
         run: |
-          bazel test --config=ci --config=ci-${{ inputs.os_name }}${{ inputs.suffix }} --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev ${{ inputs.extra_bazel_args }} //...
+          bazel test --config=ci --config=ci-${{ inputs.os_name }}${{ inputs.suffix }} --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev ${{ inputs.extra_bazel_args }} //src/workerd/api:rtti-test //src/workerd/server:server-test
       - name: Report disk usage (in MB)
         if: always()
         shell: bash
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 48ea83811d0..6339d9b3f17 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -66,8 +66,7 @@ jobs:
       image: ${{ matrix.os.image }}
       os_name: ${{ matrix.os.name }}
       suffix: ${{ matrix.config.suffix }}
-      # TODO: Debug Windows issues
-      extra_bazel_args: "--remote_download_all --noexperimental_inprocess_symlink_creation"
+      extra_bazel_args: "--config=ci-test"
     secrets:
       BAZEL_CACHE_KEY: ${{ secrets.BAZEL_CACHE_KEY }}
       WORKERS_MIRROR_URL: ${{ secrets.WORKERS_MIRROR_URL }}
diff --git a/build/js_capnp_library.bzl b/build/js_capnp_library.bzl
index 85f190fe06f..b0d13dc2994 100644
--- a/build/js_capnp_library.bzl
+++ b/build/js_capnp_library.bzl
@@ -85,7 +85,6 @@ def js_capnp_library(
         deps = [],
         src_prefix = "",
         visibility = None,
-        target_compatible_with = None,
         **kwargs):
     """Bazel rule to create a JavaScript capnproto library from capnp source files
 
@@ -97,7 +96,6 @@ def js_capnp_library(
         deps: other js_capnp_library rules to depend on
         src_prefix: src_prefix for capnp compiler to the source root
         visibility: rule visibility
-        target_compatible_with: target compatibility
         **kwargs: rest of the arguments to js_library rule
     """
 
@@ -112,13 +110,11 @@ def js_capnp_library(
         outs = js_files + d_ts_files,
         src_prefix = src_prefix,
         visibility = visibility,
-        target_compatible_with = target_compatible_with,
     )
     js_library(
         name = name,
         srcs = js_files + d_ts_files,
         deps = deps + ["//:node_modules/capnp-ts"],
         visibility = visibility,
-        target_compatible_with = target_compatible_with,
         **kwargs
     )
diff --git a/src/node/BUILD.bazel b/src/node/BUILD.bazel
index 80eba20636d..9ef5c8de4fa 100644
--- a/src/node/BUILD.bazel
+++ b/src/node/BUILD.bazel
@@ -21,5 +21,9 @@ wd_ts_bundle(
     ]),
     schema_id = "0xbcc8f57c63814005",
     tsconfig_json = "tsconfig.json",
-    deps = ["//:node_modules/@types/node"],
+    deps = [
+        "//:node_modules/@types/node",
+        "//:node_modules/@workerd/jsg",
+        "//:node_modules/capnp-ts",
+    ],
 )
diff --git a/src/pyodide/BUILD.bazel b/src/pyodide/BUILD.bazel
index a2f066831e6..0d3e9c3eaeb 100644
--- a/src/pyodide/BUILD.bazel
+++ b/src/pyodide/BUILD.bazel
@@ -198,7 +198,7 @@ js_file(
 esbuild(
     name = "generated/emscriptenSetup",
     srcs = glob([
-        "internal/pool/*",
+        "internal/pool/*.ts",
     ]) + [
         "generated/pyodide.asm.js",
         "internal/util.ts",
diff --git a/src/wpt/BUILD.bazel b/src/wpt/BUILD.bazel
index f69f00ab658..60ed0f76396 100644
--- a/src/wpt/BUILD.bazel
+++ b/src/wpt/BUILD.bazel
@@ -9,7 +9,6 @@ srcs = glob(
 
 ts_project(
     name = "wpt-test-harness",
-    testonly = False,
     srcs = srcs,
     allow_js = True,
     declaration = True,
@@ -17,6 +16,8 @@ ts_project(
     visibility = ["//visibility:public"],
     deps = [
         "//:node_modules/@types/node",
+        #"//:node_modules/@workerd/jsg",
+        "//:node_modules/capnp-ts",
     ],
 )