From 64478a0b8111e96b330acbd3c16f06036f86ef53 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 21 Nov 2024 15:13:45 -0800 Subject: [PATCH] No need to throw when closing a WritableStream that's already closing --- src/workerd/api/streams/internal.c++ | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/workerd/api/streams/internal.c++ b/src/workerd/api/streams/internal.c++ index be3ffefa20a..9a459b0caf4 100644 --- a/src/workerd/api/streams/internal.c++ +++ b/src/workerd/api/streams/internal.c++ @@ -1020,8 +1020,7 @@ void WritableStreamInternalController::setHighWaterMark(uint64_t highWaterMark) jsg::Promise WritableStreamInternalController::closeImpl(jsg::Lock& js, bool markAsHandled) { if (isClosedOrClosing()) { - auto reason = js.v8TypeError("This WritableStream has been closed."_kj); - return rejectedMaybeHandledPromise(js, reason, markAsHandled); + return js.resolvedPromise(); } if (isPiping()) { auto reason = js.v8TypeError("This WritableStream is currently being piped to."_kj);