Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing app language via System > Languages > App Languages #5755

Open
nicolas-raoul opened this issue Jun 11, 2024 · 8 comments · May be fixed by #5890
Open

Allow changing app language via System > Languages > App Languages #5755

nicolas-raoul opened this issue Jun 11, 2024 · 8 comments · May be fixed by #5890

Comments

@nicolas-raoul
Copy link
Member

Android has a standard way to change an app's language:

Screenshot 2024-06-11 at 22 16 54

You can only change the language for apps that support language selection

This does not seem to be possible for our app, it is not in the list.

If that can make implementation of this feature easier, the App user interface language item in our own Settings can be removed.

@krishnagjsForGit
Copy link

Can I work on this issue ?

@sivaraam
Copy link
Member

If that can make implementation of this feature easier, the App user interface language item in our own Settings can be removed.

I could understand that this would be good thing to support but I believe this is Android 14 specific feature. So, I don't think we could remove the "App user interface language" in the app's Settings just yet. We can get around to it at a later point in time, I suppose 🙂

@nicolas-raoul
Copy link
Member Author

@sivaraam Ah yes, removing will have to wait a good number of years. :-)

@mnalis
Copy link
Contributor

mnalis commented Jun 23, 2024

Note that such android-level per-app language chooser might have several problems (some languages, required API level, translation implementation details etc).
See streetcomplete/StreetComplete#5623 (comment) for issues encountered with implementing idea in StreetComplete OSM app (probably not all apply to Commons app, but some might).

@sivaraam
Copy link
Member

sivaraam commented Jun 23, 2024

Thank you for sharing @mnalis ! That does seem like something to be aware of while adding support for this. 👍🏼

@nicolas-raoul
Copy link
Member Author

@krishnagjsForGit I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

@Adeeth101
Copy link

@nicolas-raoul Actually our team wants to work on 2 issues. Can we first be assigned to this issue and then see if we can also be assigned to issue #5826?

@Adeeth101
Copy link

This is a PR made by my group member, please take a look at it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants