Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In the category search, redirects show up in the results but are not redirecting #6146

Open
prototyperspective opened this issue Jan 19, 2025 · 3 comments · May be fixed by #6151
Open
Assignees

Comments

@prototyperspective
Copy link

Summary

When searching for something and going to the Categories tab to see categories, it also shows redirects. This may helpful because it can help you find what you're looking for; for example in the case of taxonomic names where the colloquial name is much more popular. However, when tapping on that result, it doesn't redirect.

Steps to reproduce

  1. Open the app and tap on the search magnifier icon
  2. Enter a search term like e.g. Giraffe
  3. Go to the Categories tab to see the category results (this finally works again since the latest updates)
  4. It shows Giraffe in the search results which is what the user would select
  5. That category is a redirect and redirects to Category:Giraffa camelopardalis on desktop, but in the app it does not redirect
  6. It does not redirect and only shows "No images found!", leaving the user confused and without what the user was looking for

Expected behaviour

It should redirect. It could show the proper category directly or show a short message like "This category redirects to Giraffa camelopardalis" before loading that category in less than a second or display a note somewhere at the top or in a label at the bottom of the screen about the former category redirecting there when showing the Giraffa camelopardalis category.

Actual behaviour

It does not redirect and only shows "No images found!" (no subcategories, no parent categories), leaving the user confused and without what the user was looking for.

Device name

No response

Android version

Android

Commons app version

5.1.2

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

None

@nicolas-raoul
Copy link
Member

Indeed, thanks!

https://commons.m.wikimedia.org/wiki/Category:Giraffe

{{category redirect|Giraffa camelopardalis}}

Screenshot_20250120-072827.png

@sivaraam sivaraam self-assigned this Jan 22, 2025
@mnalis
Copy link
Contributor

mnalis commented Feb 2, 2025

This also happens to me often... It would be very nice to have a fix instead of having to manually open the commons web and have to verify and fix categories for each picture one by one

@sivaraam
Copy link
Member

sivaraam commented Feb 2, 2025

I've tried to fix the search issue in #6151. Do you have other use-cases where redirect needs to be handled? If so, could you share a specific reproduction so that I could ensure the fix works for that case too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants