Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the copy that refers to "contract address" in all input bars #74

Closed
tamarandom opened this issue Oct 27, 2023 · 4 comments · Fixed by #76
Closed

Remove the copy that refers to "contract address" in all input bars #74

tamarandom opened this issue Oct 27, 2023 · 4 comments · Fixed by #76
Labels
UAT / QA Issues logged during UAT

Comments

@tamarandom
Copy link

As we are moving this feature to a future version, we need to remove the copy which tells the user they can search by contract address.

  1. For Swap:
Screenshot 2023-10-27 at 2 38 25 PM

The text above the input bar asks which token we want to swap. But we are not entering in a token. We are entering in a DAO name. Let's change that too.

Text: "Which DAO's token do you want to swap?"
Input bar text: "Enter DAO name"

  1. For Launch / New DAO:
Screenshot 2023-10-27 at 2 43 17 PM

(the contract address prompt should never be in this flow. We have not yet created it).
Input bar text: "Enter a name for your DAO"

  1. For Launch / New DAO:
Screenshot 2023-10-27 at 2 47 45 PM

Input bar text: "Enter DAO name"
@tamarandom tamarandom added the UAT / QA Issues logged during UAT label Oct 27, 2023
@maheshchandra10
Copy link
Contributor

For the 2nd point (For Launch / New DAO), can it have the input bar text as "Enter DAO name" instead of "Enter a name for your DAO", same as the rest of the two points have? Because I can see the application is using the same single component to add these placeholders for the input box.

@tamarandom
Copy link
Author

HI @maheshchandra10 👋

For now, yes, it can! Though, eventually, they will have different text because forming a new DAO will never take a contract address as input. See #73

@maheshchandra10
Copy link
Contributor

maheshchandra10 commented Oct 27, 2023 •
edited
Loading

@tamarandom Yeah. I just asked if all the 3 input boxes can have the same placeholder as "Enter DAO name".

You have asked to add "Enter a name for your DAO" as the placeholder for the 2nd input box.
There's just a slight verbiage change between these two.

@tamarandom
Copy link
Author

Yes, I understood. And yes, it is a great idea for the short term, @maheshchandra10!
I really appreciate that you jumped in with this suggestion. 🙏

@maheshchandra10 maheshchandra10 mentioned this issue Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UAT / QA Issues logged during UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove "contract address" in all input bars maheshchandra10/ABCswap
2 participants
@tamarandom @maheshchandra10