New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie parse error #8

Closed

remoe opened this issue Mar 2, 2014 · 1 comment · May be fixed by #19

remoe commented Mar 2, 2014

Cookie value parse error when you have a cookie with '=' in value. For example, this:

https://github.com/koajs/csrf

create such values.

Author

remoe commented Mar 2, 2014

no false alarm:

  it('should set a test cookie', function(){
    cookie('test', '7LAxOjzJqw-zv3fKyNmqkITUFTmeVYMPB/mG70=');
    assert('7LAxOjzJqw-zv3fKyNmqkITUFTmeVYMPB/mG70=' == cookie('test'));
  })

update: before one set a cookie one should escape it ;)

remoe closed this as completed

matthewmueller mentioned this issue

switched to universal-cookie, added tests matthewmueller/next-cookies#21

Merged

nfriedly mentioned this issue

fix handling of = in cookie values #19

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment