Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactsSelectionBar : should show a spinner on submit button click #755

Open
JF-Cozy opened this issue Nov 5, 2020 · 0 comments
Open

Comments

@JF-Cozy
Copy link
Contributor

JF-Cozy commented Nov 5, 2020

Comme le onClick exécute une fonction async, on devrait afficher un spinner sur le bouton le temps de la suppression des contacts

Attention ConfirmDialog n'est pas re-render

https://github.com/cozy/cozy-contacts/tree/fix/spinnerDeleteButton

La modale n'étant pas un render(), il faut mettre le isBusy dans un composant a part qui render le confirmdialog. Déplacer le state depuis ContactsSelectionBar vers ContactsSelectionBarConfirmDialog.

On pourrait en profiter pour simplifier et supprimer showModal() au passage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant