Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest: Merge KonnectorJobWatcher and KonnectorAccountWatcher into KonnectorJob #570

Open
gregorylegarec opened this issue Jul 1, 2019 · 2 comments
Open

Harvest: Merge KonnectorJobWatcher and KonnectorAccountWatcher into KonnectorJob #570

gregorylegarec opened this issue Jul 1, 2019 · 2 comments
Assignees
@y-lohse

Comments

@gregorylegarec
Copy link
Contributor

The KonnectorJob model should be the main interface for watching konnector job and account. KonnectorAccountWatcher and KonnectorJobWatcher share some redundant logic and could be merged directly into KonnectorJob.

When refactoring, we must take care to properly unsubscribe to Konnector Job event, as suggested here #567 (comment)
@gregorylegarec gregorylegarec mentioned this issue Jul 1, 2019
Merged
@y-lohse
Copy link
Contributor

y-lohse commented Aug 26, 2019

Done in #736.

@y-lohse y-lohse closed this as completed Aug 28, 2019
@ptbrowne
Copy link
Contributor

I am reopening because it seems that KonnectorAccountWatcher and KonnectorJobWatcher are still alive and well and I think it might make sense to merge them.

https://github.com/cozy/cozy-libs/search?q=KonnectorAccountWatcher&unscoped_q=KonnectorAccountWatcher
https://github.com/cozy/cozy-libs/search?q=KonnectorJobWatcher&unscoped_q=KonnectorJobWatcher

@ptbrowne ptbrowne reopened this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y-lohse y-lohse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ptbrowne @gregorylegarec @y-lohse