Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest: Wrap KonnectorModal with withKonnector HOC #683

Open
gregorylegarec opened this issue Jul 25, 2019 · 0 comments
Open

Harvest: Wrap KonnectorModal with withKonnector HOC #683

gregorylegarec opened this issue Jul 25, 2019 · 0 comments

Comments

@gregorylegarec
Copy link
Contributor

For now KonnectorModal component requires a konnector props, fully fetched with its related triggers into konnector.triggers.data.

It implies that the calling application must fetch konnector and its triggers before rendering a KonnectorModal.

I think we should wrap the KonnectorModal with a withKonnector HOC, in charge of fetching everything is needed (konnector, triggers, but also related accounts) before injecting it into KonnectorModal. We could then call the KonnectorModal this way:

<KonnectorModal slug="trainline" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant