-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Buffer in node environment #180
Conversation
You just removed an assert and created a local variable that isn't used anywhere. This code makes no sense. |
@junderw copypaste gone wrong, sorry :) |
@junderw any updates? |
Why do we need this change? |
Lol, I tried to reproduce it again so I can properly explain but I couldn't. I had a problem with the validation when trying to sign a transaction with a ledger hardware wallet, cannot reproduce it anymore 🤷♂️ I'm sorry |
@fanatid I managed to reproduce this again The error happens within this snippet:
|
I haven't had time to dive in into |
Fixes #175If I understand correctly, Buffer is a subclass of Uint8Array that extends it, thus it should be ok to use Buffer.
API reference mentions that the browser's Buffer is lacking behind, this is why I included
isNode
flag