From ea98639e02c00cef1304c84c2e0fcb1ca22a315d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 28 Jan 2025 20:20:34 +0100 Subject: [PATCH] Fix: abstract EventLoop::Polling#system_add invalid signature (#15380) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The abstract method refers to the non existing `Index` type. Weirdly the compiler won't complain until someone defines an `Index` type. Resolves #15357 (cherry picked from commit 5a245d905717ff9ea8a62512d8a5e0fefa721959) Co-authored-by: Johannes Müller --- src/crystal/event_loop/polling.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crystal/event_loop/polling.cr b/src/crystal/event_loop/polling.cr index 2fe86ad5b649..3eb17c0e313e 100644 --- a/src/crystal/event_loop/polling.cr +++ b/src/crystal/event_loop/polling.cr @@ -515,7 +515,7 @@ abstract class Crystal::EventLoop::Polling < Crystal::EventLoop private abstract def system_run(blocking : Bool, & : Fiber ->) : Nil # Add *fd* to the polling system, setting *index* as user data. - protected abstract def system_add(fd : Int32, index : Index) : Nil + protected abstract def system_add(fd : Int32, index : Arena::Index) : Nil # Remove *fd* from the polling system. Must raise a `RuntimeError` on error. #