Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate reason to client-side FutureCancelledError when closing the scheduler #8830

Open
hendrikmakait opened this issue Aug 13, 2024 · 0 comments
Labels
enhancement Improve existing functionality or make things work better

Comments

@hendrikmakait
Copy link
Member

Scheduler.close takes a reason keyword which allows us to provide additional context. However, when it comes to cancelling client-side futures, we simply abort the comm causing the Client to cancel the futures with reason=scheduler-connection-lost. It would be great if we could propagate the closing reason to the client and use it when cancelling futures in order to help users understand what's happening. For example, if the scheduler shuts down due to the idle-timeout kicking in, it would be great it we told the users that the futures were cancelled because we exceeded the timeout, not because we lost the connection due to some unknown reason.

@hendrikmakait hendrikmakait added the enhancement Improve existing functionality or make things work better label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better
Projects
None yet
Development

No branches or pull requests

1 participant