Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider split into multiple actions? #198

Open
jcbhmr opened this issue Aug 18, 2023 · 3 comments
Open

consider split into multiple actions? #198

jcbhmr opened this issue Aug 18, 2023 · 3 comments

Comments

@jcbhmr
Copy link

jcbhmr commented Aug 18, 2023

hello! 👋

problem: what if a company, org, or institution theoretically wants to do this:
image
(this is THEORETICAL and i haven't actually encountered this)

but only for the docs generation part. or only for the publishing part. or only for publishing features but not templates... what do they do? its all or nothing since everything is in this single action 🤣

i notice that this organization very much favors monorepo pattern so i dont know if this is even remotely possible 🤷‍♀️ but its something id like to see considered 😀

@samruddhikhandale
Copy link
Member

Hi 👋

Thank you @jcbhmr for always coming up with intriguing questions, we appreciate it 👏

but only for the docs generation part. or only for the publishing part. or only for publishing features but not templates... what do they do? its all or nothing since everything is in this single action 🤣

Yep, we have a single action which supports different features. However, it is intentionally created for simplicity and convenience. We could split it into different actions, but I don't think we should split it unless it's necessary. Also, the community seems to have been using this action for a while, splitting it into different actions and eventually deprecating this one might not be the best user experience.

However, we can keep this issue open, see if we get more feedback from the community and we could re-iterate if necessary. Let me know this makes sense.

// cc @joshspicer @bamurtaugh for any other thoughts.

@jcbhmr
Copy link
Author

jcbhmr commented Aug 22, 2023

idea: could you split it into multiple actions and then have the original action just wrap the other actions?

for example i recently converted a sync-secrets action to a bunch of independent actions. it was quite helpful to be able to pluck for instance just the list-secrets part while still maintaining the larger wrapping sync-secrets action.

@bamurtaugh
Copy link
Member

bamurtaugh commented Aug 22, 2023

Yes, thank you @jcbhmr for always sharing great ideas with us!

I think what @samruddhikhandale shares makes a lot of sense - let's monitor feedback here to see if this turns out to be a wider spread issue folks are experiencing today or start experiencing in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants