Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types are not used #165

Open
leoseccia opened this issue Jan 16, 2018 · 3 comments
Open

Types are not used #165

leoseccia opened this issue Jan 16, 2018 · 3 comments

Comments

@leoseccia
Copy link

leoseccia commented Jan 16, 2018

Throughout the library, all variables are of type string . This is a real shame - I suggest changing the variable types to reflect the data they hold.

As it is at the moment, the api is unnecessarily confusing to use because of it.

@Socrathustra
Copy link

Seconded. I find it frustrating to have to know the magic string values for things like status. At the very least, significant values ought to be enums, constants, or static readonly variables. Adopting the "no magic strings" policy has dramatically increased the quality of my own code and would do wonders for this library.

@LarryKlugerDS
Copy link
Contributor

Yes, we agree! This enhancement is on our roadmap but is not yet scheduled. It is filed as internal ticket EC-1104.

Please ask your DocuSign business or technical contact to add your organization's name to the ticket. Thank you for raising the issue.

@adamhathcock
Copy link

I'd like this for at least scalar types like DateTime or DateTimeOffset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants