Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate necessity of delay to keep node coloring from disappearing when using expression db to do node coloring on workbook with no expression data #865

Open
afiller1 opened this issue Apr 30, 2020 · 1 comment

Comments

@afiller1
Copy link
Collaborator

In my last PR, I had encountered a bug where, when the user uploads a workbook with no expression data and does node coloring using the database, when they change the node configuration (from force graph to grid layout, for instance), node coloring goes away. It was getting where it needed to in the code and calling all the right functions... @dondi and I looked at it together and were a bit stumped as to why this was happening. Dondi came up with a temporary workaround (see lines 767 to 780 or so) of web-client\public\js\update-app.js for further details.

Even though we have this workaround in place, it would be good for us to know why this delay is needed, and especially why it's only needed for this specific example (it was working fine when expression data was used to do node coloring when the workbook already had expression data present).

@kdahlquist
Copy link
Collaborator

Is this issue still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants