You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Investigate necessity of delay to keep node coloring from disappearing when using expression db to do node coloring on workbook with no expression data
#865
Open
afiller1 opened this issue
Apr 30, 2020
· 1 comment
In my last PR, I had encountered a bug where, when the user uploads a workbook with no expression data and does node coloring using the database, when they change the node configuration (from force graph to grid layout, for instance), node coloring goes away. It was getting where it needed to in the code and calling all the right functions... @dondi and I looked at it together and were a bit stumped as to why this was happening. Dondi came up with a temporary workaround (see lines 767 to 780 or so) of web-client\public\js\update-app.js for further details.
Even though we have this workaround in place, it would be good for us to know why this delay is needed, and especially why it's only needed for this specific example (it was working fine when expression data was used to do node coloring when the workbook already had expression data present).
The text was updated successfully, but these errors were encountered:
In my last PR, I had encountered a bug where, when the user uploads a workbook with no expression data and does node coloring using the database, when they change the node configuration (from force graph to grid layout, for instance), node coloring goes away. It was getting where it needed to in the code and calling all the right functions... @dondi and I looked at it together and were a bit stumped as to why this was happening. Dondi came up with a temporary workaround (see lines 767 to 780 or so) of web-client\public\js\update-app.js for further details.
Even though we have this workaround in place, it would be good for us to know why this delay is needed, and especially why it's only needed for this specific example (it was working fine when expression data was used to do node coloring when the workbook already had expression data present).
The text was updated successfully, but these errors were encountered: