Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise GRNsight people page to match GRNmap layout more closely #872

Open
dondi opened this issue Sep 11, 2020 · 2 comments
Open

Revise GRNsight people page to match GRNmap layout more closely #872

dondi opened this issue Sep 11, 2020 · 2 comments
Labels

Comments

@dondi
Copy link
Owner

dondi commented Sep 11, 2020

This will avoid the minimum-window-width issue that currently pushes the photo off the second column.

  • Add carousel (photos in assets/images)
  • Move photo above investigators+students
  • Investigators and students in two columns
@dondi
Copy link
Owner Author

dondi commented Sep 18, 2020

I took a stab at updating this page and ran into an older issue that has now come back to haunt us, in a sense—in the very early days of this website, a custom Bootstrap CSS file was put together due to some visual glitches that the full, official Bootstrap CSS apparently manifested on GRNsight. Unfortunately, this full version is necessary in order to implement the carousel.

I briefly switched to this full version and the primary visual issue that I noticed was looser spacing on the sidebar menu (see screenshot). Font sizes also appear to be mismatched. There may be other visual issues on other pages but this is the one that popped out immediately.

image

After this switch is made, some adjustments need to be done on the image styling itself (as can also be seen in the screenshot) but at least the core functionality would be there.

Because of these side effects, I held back on the big switch but at least adjusted the layout to place the picture at the top with the people listing in two columns in a way that appears to handle variable window widths a little better. So there is that at least.

It looks like a full carousel switch will also require whatever adjustments are needed in order to use the full, unmodified Bootstrap CSS. It looks like the GRNmap site was able to make this transition; a similar transition will be needed for GRNsight.

@dondi
Copy link
Owner Author

dondi commented Aug 29, 2023

Purely a website visual issue—will unassign for now and this may perhaps be a better match for a future student to do

@dondi dondi removed their assignment Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant