Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RazorProjectExtensions.GetSourceGeneratedDocumentsForGeneratorAsync should only consider the path and generator name #76869

Open
chsienki opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@chsienki
Copy link
Contributor

RazorProjectExtensions.GetSourceGeneratedDocumentsForGeneratorAsync constructs the entire generator identity before comparing. This has issues with path matching though as it considers the paths in a case-sensitive way. The assembly mapping logic in Roslyn uses the path returned by the VSIX apis which upper cases a large portion of the assembly path, meaning the identities don't match when Roslyn loads the razor generator first.

Instead of taking the entire identity we should just consider the path and name of the generator. When considering the path we should do it in a platform correct manor (i.e. case insensitive on windows)

@chsienki chsienki self-assigned this Jan 22, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

1 participant