Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllocateArrayWithNonGCElements test fails on NativeAOT #111822

Closed
jkotas opened this issue Jan 25, 2025 · 4 comments · Fixed by #111827
Closed

AllocateArrayWithNonGCElements test fails on NativeAOT #111822

jkotas opened this issue Jan 25, 2025 · 4 comments · Fixed by #111827
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged

Comments

@jkotas
Copy link
Member

jkotas commented Jan 25, 2025

Fails in runtime-nativeaot-outerloop

Example of the log: https://dev.azure.com/dnceng-public/public/_build/results?buildId=928364&view=ms.vss-test-web.build-test-results-tab&runId=24573328&resultId=115775&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

FAILURE (AllocateArrayWithNonGCElements): unexpected allocation of 192 bytes
@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-NativeAOT-coreclr labels Jan 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 25, 2025
@jkotas jkotas added blocking-clean-ci-optional Blocking optional rolling runs area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Jan 25, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas added the untriaged New issue has not been triaged by the area owner label Jan 25, 2025
@jkotas
Copy link
Member Author

jkotas commented Jan 25, 2025

Likely introduced by #104906. cc @hez2010 @AndyAyersMS

@hez2010
Copy link
Contributor

hez2010 commented Jan 25, 2025 •
edited
Loading

This is a newly added test to ensure that the array is allocated on the stack.
From the test failure, it seems that somehow the JIT decides to allocate the array in the test on the heap in NativeAOT instead.
This is an optimization and doesn't harm the correctness. We can temporarily disable this test for NativeAOT while investigating the cause.

@hez2010 hez2010 mentioned this issue Jan 25, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jan 25, 2025
@hez2010
Copy link
Contributor

hez2010 commented Jan 25, 2025 •
edited
Loading

It turns out that we disabled the optimization on NativeAOT by accident when trying to disable it for R2R. The fix is #111827.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Projects
AppModel
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JIT: Fix stack allocated arrays for NativeAOT hez2010/runtime
2 participants
@jkotas @hez2010