-
Notifications
You must be signed in to change notification settings - Fork 63
/
Copy pathApplyDefaultInsteadOfNullCoalesceRector.php
145 lines (127 loc) · 4.41 KB
/
ApplyDefaultInsteadOfNullCoalesceRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
<?php
namespace RectorLaravel\Rector\Coalesce;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\BinaryOp\Coalesce;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Throw_;
use PHPStan\Type\ObjectType;
use Rector\Contract\Rector\ConfigurableRectorInterface;
use RectorLaravel\AbstractRector;
use RectorLaravel\ValueObject\ApplyDefaultInsteadOfNullCoalesce;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;
/**
* @see \RectorLaravel\Tests\Rector\Coalesce\ApplyDefaultInsteadOfNullCoalesceRector\ApplyDefaultInsteadOfNullCoalesceRectorTest
*/
final class ApplyDefaultInsteadOfNullCoalesceRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @var ApplyDefaultInsteadOfNullCoalesce[]
*/
private array $applyDefaultWith;
public function __construct()
{
$this->applyDefaultWith = self::defaultLaravelMethods();
}
/**
* @return ApplyDefaultInsteadOfNullCoalesce[]
*/
public static function defaultLaravelMethods(): array
{
return [
new ApplyDefaultInsteadOfNullCoalesce('config'),
new ApplyDefaultInsteadOfNullCoalesce('env'),
new ApplyDefaultInsteadOfNullCoalesce('data_get', argumentPosition: 2),
new ApplyDefaultInsteadOfNullCoalesce('input', new ObjectType('Illuminate\Http\Request')),
new ApplyDefaultInsteadOfNullCoalesce('get', new ObjectType('Illuminate\Support\Env')),
];
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Apply default instead of null coalesce',
[
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
custom_helper('app.name') ?? 'Laravel';
CODE_SAMPLE,
<<<'CODE_SAMPLE'
custom_helper('app.name', 'Laravel');
CODE_SAMPLE
,
[
...self::defaultLaravelMethods(),
new ApplyDefaultInsteadOfNullCoalesce('custom_helper'),
],
),
]
);
}
public function getNodeTypes(): array
{
return [Coalesce::class];
}
/**
* @param Coalesce $node
*/
public function refactor(Node $node): MethodCall|StaticCall|FuncCall|null
{
if (! $node->left instanceof FuncCall &&
! $node->left instanceof MethodCall &&
! $node->left instanceof StaticCall
) {
return null;
}
if ($node->left->isFirstClassCallable()) {
return null;
}
$call = $node->left;
if ($call instanceof MethodCall) {
$objectType = $call->var;
} elseif ($call instanceof StaticCall) {
$objectType = $call->class;
} else {
$objectType = null;
}
foreach ($this->applyDefaultWith as $applyDefaultWith) {
$valid = false;
if (
$applyDefaultWith->getObjectType() !== null &&
$objectType instanceof Node &&
$this->isObjectType(
$objectType,
$applyDefaultWith->getObjectType()) &&
$this->isName($call->name, $applyDefaultWith->getMethodName()) &&
! $node->right instanceof Throw_
) {
$valid = true;
} elseif (
$applyDefaultWith->getObjectType() === null &&
$this->isName($call->name, $applyDefaultWith->getMethodName()) &&
! $node->right instanceof Throw_
) {
$valid = true;
}
if (! $valid) {
continue;
}
if (count($call->args) === $applyDefaultWith->getArgumentPosition()) {
if ($this->getType($node->right)->isNull()->yes()) {
return $call;
}
$call->args[count($call->args)] = new Arg($node->right);
return $call;
}
}
return null;
}
public function configure(array $configuration): void
{
Assert::allIsInstanceOf($configuration, ApplyDefaultInsteadOfNullCoalesce::class);
$this->applyDefaultWith = $configuration;
}
}