Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend docker_guiapp.sh #2

Open
eine opened this issue Apr 10, 2018 · 0 comments
Open

Extend docker_guiapp.sh #2

eine opened this issue Apr 10, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@eine
Copy link
Owner

eine commented Apr 10, 2018 •
edited
Loading

Right now, it is only tested with Xming on Windows, and the path is fixed. Possible enhancements:

  • Allow the user to set the path where Xming is installed.
  • Add support for VcXsrv.
  • Add support for Cygwin/X.

Also, check if the terminal is a tty before using $(command -v winpty), in order to allow curl -L https://....docker_guiapp.sh | sh. See https://stackoverflow.com/questions/911168/how-to-detect-if-my-shell-script-is-running-through-a-pipe
@eine eine added the enhancement New feature or request label Apr 10, 2018
@eine eine changed the title Extend docker_guiapp.sh Extend docker_guiapp.sh Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eine