Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bars instead of the current async output #24

Open
elboletaire opened this issue Nov 13, 2023 · 0 comments · May be fixed by #40
Open

Add progress bars instead of the current async output #24

elboletaire opened this issue Nov 13, 2023 · 0 comments · May be fixed by #40
Labels
enhancement New feature or request

Comments

@elboletaire
Copy link
Owner

elboletaire commented Nov 13, 2023 •
edited
Loading

Show downloading progress with progress bars, instead of the current asynchronous verbosity.

i.e. https://github.com/jedib0t/go-pretty/blob/main/progress/README.md
@elboletaire elboletaire added the enhancement New feature or request label Nov 13, 2023
elboletaire added a commit that referenced this issue May 12, 2024
@elboletaire
Adding progress bars
49c1157 
- Progress bars for downloading and archiving single chapters
- Progress bar for the bundle, although the other ones should be
  improved in this case
- Removed logs and other console outputs here and there.
- Errors are still NOT properly managed in the progress bars. A channel
  decorator should be used for that.

refs #24
@elboletaire elboletaire linked a pull request May 12, 2024 that will close this issue
Open
elboletaire added a commit that referenced this issue May 18, 2024
@elboletaire
Adding progress bars
2ad147a 
- Progress bars for downloading and archiving single chapters
- Progress bar for the bundle, although the other ones should be
  improved in this case
- Removed logs and other console outputs here and there.
- Errors are still NOT properly managed in the progress bars. A channel
  decorator should be used for that.

refs #24
elboletaire added a commit that referenced this issue Jan 2, 2025
@elboletaire
Add progress bars
8b22c29 
refs #24
elboletaire added a commit that referenced this issue Jan 2, 2025
@elboletaire
Always try to keep the downloaded title in the same position
a37562e 
Also got the terminal width in order to not truncate when it's not
necessary

refs #24
elboletaire added a commit that referenced this issue Jan 2, 2025
@elboletaire
refs #24 improve progress bars behavior
935f4b6 
- Fix archiving progress bar not showing correctly for TCB sites
- Keep clean progress bar style with minimal status messages
- Fix progress increments to match actual archiving progress
- Code clean-up
elboletaire added a commit that referenced this issue Jan 7, 2025
@elboletaire
refs #24 fix: restore original download mechanism
372a2ff 
- Pre-allocate files slice to ensure all pages are captured
- Use direct indexing instead of append to prevent missing files
- Simplify synchronization while maintaining progress bar improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Progress bars elboletaire/manga-downloader
1 participant
@elboletaire