From b0c3e5208edd6352b6eecfb557e601db651b0b22 Mon Sep 17 00:00:00 2001 From: AdrianSosic Date: Wed, 29 Jan 2025 15:26:20 +0100 Subject: [PATCH] Change allow_recommending_already_recommended default to False --- CHANGELOG.md | 5 +++++ baybe/campaign.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 363542432..13a8ceccf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [0.12.1] - 2025-01-29 +### Changed +- Default of `allow_recommending_already_recommended` is changed back to `False` + to avoid exploitation cycles ([#468](https://github.com/emdgroup/baybe/issues/468)) + ## [0.12.0] - 2025-01-28 ### Breaking Changes - Lookup callables for simulation are now expected to accept/return dataframes with diff --git a/baybe/campaign.py b/baybe/campaign.py index 96af970f9..21c8dbf38 100644 --- a/baybe/campaign.py +++ b/baybe/campaign.py @@ -133,7 +133,7 @@ class Campaign(SerialMixin): allow_recommending_already_recommended: bool | UnspecifiedType = field( default=Factory( - _make_allow_flag_default_factory(default=True), takes_self=True + _make_allow_flag_default_factory(default=False), takes_self=True ), validator=_validate_allow_flag, kw_only=True,