Introduce traits for SidePanel and TopBottomPanel #5651
+344
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: it would have been better to name it `trait Side`, but without renaming `enum Side`, it is not possible.
|
EDIT: Seems that removing the I have some trouble with + ./scripts/lint.py
./crates/egui/src/containers/panel.rs:72: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:77: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:80: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:83: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:86: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:89: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:92: builder methods should be marked #[inline]
./crates/egui/src/containers/panel.rs:95: builder methods should be marked #[inline]+ ./scripts/lint.py
./scripts/lint.py finished without error
+ cargo fmt --all -- --check
+ cargo doc --quiet --lib --no-deps --all-features
[...]
error: `#[inline]` is ignored on function prototypes
--> crates/egui/src/containers/panel.rs:72:5
|
72 | #[inline]
| ^^^^^^^^^
|
= note: `-D unused-attributes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_attributes)]`
|
|
Ran the test locally, I have the following result: |
|
Turns out, my idea wasn't as easy to implement that I expected (Rust beginner here 😅). I'll rethink this a bit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paneltrait forSidePanelandTopBottomPanel#5643I made the change against 0.30.0 for now to test in my own code if that work like I hoped. I will bring the changes in master afterwards.