Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recipe note about a bug in Node.js <18.7.0 #972

Open
ericcornelissen opened this issue Jun 18, 2023 · 0 comments
Open

Remove recipe note about a bug in Node.js <18.7.0 #972

ericcornelissen opened this issue Jun 18, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation pending This cannot be worked on yet

Comments

@ericcornelissen
Copy link
Owner

Documentation

Relates to #193, #356

Description

When Node.js <18.7.0 is no longer supported by this library remove the note about a bug in Node.js <18.7.0. Specifically this note:

shescape/docs/recipes.md

Lines 285 to 287 in b2e1661

> **Warning**: Due to a bug in Node.js (<18.7.0), using `execFileSync` with a
> shell may result in `args` not being passed properly to the `command`,
> depending on the shell being used. See [nodejs/node#43333].

Motivation

Based on the release dates - listed below - I expect that no version >=18.7.0 is affected by the bug in question. If this is incorrect, please leave a comment with more details (affected versions and corresponding references).

Node.js version Release date Release notes
18.7.0 2022-07-26 link
19.0.0 2022-10-18 link
20.0.0 2023-04-18 link
@ericcornelissen ericcornelissen added documentation Improvements or additions to documentation pending This cannot be worked on yet labels Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pending This cannot be worked on yet
Projects
None yet
Development

No branches or pull requests

1 participant