Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non-boolean experimental flags in 3.6 #19141

Open
3 of 11 tasks
siyuanfoundation opened this issue Jan 7, 2025 · 8 comments · Fixed by #19156
Open
3 of 11 tasks

Migrate non-boolean experimental flags in 3.6 #19141

siyuanfoundation opened this issue Jan 7, 2025 · 8 comments · Fixed by #19156

Comments

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Jan 7, 2025

What would you like to be added?

For the 3.6 release, we would like to have the list of non-boolean --experimental flags migrated to flags without the --experimental prefix.

In 3.6, we would like to have both the flags with and without the --experimental prefix working. experimentalNonBoolFlagMigrationMap should be used to achieve that. #19156 is an example.

Why is this needed?

flag clean up for release 3.6

@siyuanfoundation
Copy link
Contributor Author

@ahrtr @serathius Please double check the flag list and see if any flag needs to remain --experimental or missing any.

@siyuanfoundation
Copy link
Contributor Author

/cc @gangli113

@gangli113
Copy link
Contributor

/assign

@siyuanfoundation
Copy link
Contributor Author

/reopen
because there are still other flags to migrate.

@ahrtr
Copy link
Member

ahrtr commented Jan 23, 2025

More contributors are welcome to work on this to accelerate it.

@ajaysundark
Copy link
Contributor

I can take a look at some -

randomly self-assigning half of the set

experimental-snapshot-catch-up-entries
experimental-compaction-sleep-interval
experimental-downgrade-check-time
experimental-set-member-localaddr

/assign

@ajaysundark
Copy link
Contributor

From community meeting, the ask here is not to 'graduate' the flags. But experimental nature of the feature to be descriptive in a way that's non-blocking, instead of having to rename the flag breaking the users during graduation.

cc: @serathius @ahrtr @siyuanfoundation

@ahrtr
Copy link
Member

ahrtr commented Jan 23, 2025

From community meeting, the ask here is not to 'graduate' the flags. But experimental nature of the feature to be descriptive in a way that's non-blocking, instead of having to rename the flag breaking the users during graduation.

cc: @serathius @ahrtr @siyuanfoundation

Yes, we are NOT graduating or deprecating any flags in this effort ( which is a separate effort). We are just changing the way to manage these experimental flags for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants