Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to control the discretization of colormap #228

Open
xyont opened this issue Feb 15, 2022 · 10 comments · May be fixed by #1678
Open

Add an option to control the discretization of colormap #228

xyont opened this issue Feb 15, 2022 · 10 comments · May be fixed by #1678
Assignees
@gapry
Labels
good first issue Good for newcomers help wanted Please help with this issue!
Milestone
3.1.0

Comments

@xyont
Copy link

xyont commented Feb 15, 2022 •
edited by mwestphal
Loading

Context
F3D is able to display data using a color map. By default, the discretization of the colormap is 256. It would be nice to add a way to control that discretization.

Suggested Solution

  • Add a CLI option (--colormap-discretization) in F3DOptionParser
  • Add a libf3d option (model.scivis.discretization) in options
  • Add a dedicated member in vtkF3DRendererWithColoring and takes it into account in ConfigureRangeAndCTFForColoring

Original Issue

dear Developers,

i did not know is this feature available yet or not, several times i read the documentation but i can not find for such purpose.

Paraview has capability to setting number of color discretization, hopefully is not complex things and F3D also capable to do the same. it's a common in engineering representation.

best regards,
SN

F3d_256discrettation
Paravie_Number_Color_Discrtization_12
@mwestphal
Copy link
Contributor

What about using Step color space ?

@Meakk
Copy link
Member

Meakk commented Feb 15, 2022

I think it's unrelated to step color space, just the number of computed colors in the lookup table.
We could use vtkDiscretizableColorTransferFunction and add a new option to set the number of colors.

@mwestphal
Copy link
Contributor

Indeed, but being able to choose the step color space resolve the usecase in a different way and open the door to other color spaces.

@mwestphal
Copy link
Contributor

That being said, adding the number of colors should be quite an easy feature to add. Feel free to contribute if you can @xyont

@xyont
Copy link
Author

xyont commented Feb 21, 2022

i'm new to graphics especially in VTK, not a really programmer also. however, it's interesting subject in which lead me to start learn something.

@mwestphal mwestphal added the good first issue Good for newcomers label Jul 5, 2023
@mwestphal mwestphal added the help wanted Please help with this issue! label Jan 7, 2024
@mwestphal
Copy link
Contributor

Added context and suggested solution.

@mwestphal mwestphal changed the title possibility to setting number of color discretization Add an option to control the discretization of colormap Jan 22, 2024
@mwestphal mwestphal mentioned this issue Feb 3, 2024
Closed
@mwestphal mwestphal added this to F3D Feb 3, 2024
@MarcosDanielTorres
Copy link
Contributor

Hi! Maybe I can take this?

@mwestphal
Copy link
Contributor

Sure!

@mwestphal mwestphal added this to the 2.4.0 milestone Feb 5, 2024
@mwestphal mwestphal moved this to In progress in F3D Feb 5, 2024
@MarcosDanielTorres MarcosDanielTorres removed their assignment Feb 29, 2024
@Meakk Meakk moved this from In progress to To do in F3D Mar 2, 2024
@mwestphal mwestphal modified the milestones: 2.4.0, 2.5.0 Apr 4, 2024
@mwestphal mwestphal modified the milestones: 2.5.0, 3.0.0 Jul 3, 2024
@mwestphal mwestphal modified the milestones: 3.0.0, 3.1.0 Jul 13, 2024
@gapry
Copy link

gapry commented Oct 7, 2024

@mwestphal I'd like to work on this issue. Could you please assign it to me?

@mwestphal
Copy link
Contributor

Of course! Feel free to join our discord if you want :)

https://discord.f3d.app

@gapry gapry linked a pull request Oct 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gapry gapry

Labels
good first issue Good for newcomers help wanted Please help with this issue!
Projects
F3D
Status: To do
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Feature: Add an option to control the discretization of colormap gapry/f3d
5 participants
@mwestphal @gapry @Meakk @MarcosDanielTorres @xyont