Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong birthplace code [F991] #210

Open
cvrboni opened this issue Dec 2, 2024 · 3 comments
Open

Wrong birthplace code [F991] #210

cvrboni opened this issue Dec 2, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cvrboni
Copy link

cvrboni commented Dec 2, 2024

Python version
3.10

Package version
0.10.3

Current behavior (bug description)
ValueError: [codicefiscale] wrong birthplace code: 'F991' / birthdate: '1930-06-14T00:00:00'.

Expected behavior
Correct birthplace should be Nuxis

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@cvrboni cvrboni added the bug Something isn't working label Dec 2, 2024
@fabiocaccamo fabiocaccamo moved this to Todo in Open Source Dec 2, 2024
@fabiocaccamo
Copy link
Owner

@cvrboni did the problem occurred during decoding?

@cvrboni
Copy link
Author

cvrboni commented Jan 23, 2025

@cvrboni did the problem occurred during decoding?

yes, if it helps, I had noticed that in the municipalities.json file for the municipality of Nuxis the data started from 1958, and therefore returned an error for that (this was a person from 1930), I had modified the file by hand by starting a data from 1920 and no longer returned the error, but the municipality itself was born in 1957 so it was still consistent with the data from before

@fabiocaccamo
Copy link
Owner

@cvrboni thank you for the feedback.

So the solution would be to add a fallback for returning the first matching municipality activated after the birthdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants